| From | Greg Kroah-Hartman <> | Subject | [PATCH 4.2 010/124] net: fec: Remove unneeded use of IS_ERR_VALUE() macro | Date | Mon, 7 Dec 2015 09:55:00 -0500 |
| |
4.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Fabio Estevam <fabio.estevam@freescale.com>
[ Upstream commit b0c6ce24911fcb64715de9569f0f7b4f54d1d045 ]
There is no need to use the IS_ERR_VALUE() macro for checking the return value from pm_runtime_* functions.
Just do a simple negative test instead.
The semantic patch that makes this change is available in scripts/coccinelle/api/pm_runtime.cocci.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/net/ethernet/freescale/fec_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
--- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -1775,7 +1775,7 @@ static int fec_enet_mdio_read(struct mii int ret = 0; ret = pm_runtime_get_sync(dev); - if (IS_ERR_VALUE(ret)) + if (ret < 0) return ret; fep->mii_timeout = 0; @@ -1814,7 +1814,7 @@ static int fec_enet_mdio_write(struct mi int ret = 0; ret = pm_runtime_get_sync(dev); - if (IS_ERR_VALUE(ret)) + if (ret < 0) return ret; fep->mii_timeout = 0; @@ -2866,7 +2866,7 @@ fec_enet_open(struct net_device *ndev) int ret; ret = pm_runtime_get_sync(&fep->pdev->dev); - if (IS_ERR_VALUE(ret)) + if (ret < 0) return ret; pinctrl_pm_select_default_state(&fep->pdev->dev);
|