lkml.org 
[lkml]   [2015]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.3 013/125] ipv6: clean up dev_snmp6 proc entry when we fail to initialize inet6_dev
    Date
    4.3-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Sabrina Dubroca <sd@queasysnail.net>

    [ Upstream commit 2a189f9e57650e9f310ddf4aad75d66c1233a064 ]

    In ipv6_add_dev, when addrconf_sysctl_register fails, we do not clean up
    the dev_snmp6 entry that we have already registered for this device.
    Call snmp6_unregister_dev in this case.

    Fixes: a317a2f19da7d ("ipv6: fail early when creating netdev named all or default")
    Reported-by: Dmitry Vyukov <dvyukov@google.com>
    Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/ipv6/addrconf.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/net/ipv6/addrconf.c
    +++ b/net/ipv6/addrconf.c
    @@ -417,6 +417,7 @@ static struct inet6_dev *ipv6_add_dev(st
    if (err) {
    ipv6_mc_destroy_dev(ndev);
    del_timer(&ndev->regen_timer);
    + snmp6_unregister_dev(ndev);
    goto err_release;
    }
    /* protected by rtnl_lock */



    \
     
     \ /
      Last update: 2015-12-07 17:01    [W:4.094 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site