Messages in this thread | | | From | Haggai Eran <> | Subject | Re: [PATCH] infiniband:core:Add needed error path in cm_init_av_by_path | Date | Mon, 7 Dec 2015 07:57:33 +0000 |
| |
On Friday, December 4, 2015 8:02 PM, Nicholas Krause <xerofoify@gmail.com> wrote: > To: dledford@redhat.com > Cc: sean.hefty@intel.com; hal.rosenstock@gmail.com; Haggai Eran; jgunthorpe@obsidianresearch.com; Matan Barak; yun.wang@profitbricks.com; ted.h.kim@oracle.com; Doron Tsur; Erez Shitrit; david.ahern@oracle.com; linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] infiniband:core:Add needed error path in cm_init_av_by_path > > This adds a needed error path in the function, cm_init_av_by_path > after the call to ib_init_ah_from_path in order to avoid incorrectly > accessing the path pointer of structure type ib_sa_path_rec if this > function call fails to complete its intended work successfully by > returning a error code. > > Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
The subject doesn't seem to match the convention but apart from that,
Reviewed-by: Haggai Eran <haggaie@mellanox.com>
I wonder if this should go to stable. If I understand correctly, this will fail only when the SGID isn't found in the GID table, but such connections would fail later on when creating a QP, right?
Haggai
| |