[lkml]   [2015]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 4.3 105/125] usb: chipidea: debug: disable usb irq while role switch
4.3-stable review patch.  If anyone has any objections, please let me know.


From: Li Jun <>

commit 251b3c8b57481bcecd3f753108e36e7389ce12ac upstream.

Since the ci->role will be set after the host role start is complete, there
will be nobody cared irq during start host if usb irq enabled. This error
can be reproduced on i.mx6 sololite EVK board by:
1. disable otg id irq(IDIE) and disable all real otg properties of usbotg1
in dts.
2. boot up the board with ID cable and usb device connected.
3. echo gadget > /sys/kernel/debug/ci_hdrc.0/role
4. echo host > /sys/kernel/debug/ci_hdrc.0/role
5. irq 212: nobody cared.

Signed-off-by: Li Jun <>
Signed-off-by: Peter Chen <>
Signed-off-by: Greg Kroah-Hartman <>

drivers/usb/chipidea/debug.c | 2 ++
1 file changed, 2 insertions(+)

--- a/drivers/usb/chipidea/debug.c
+++ b/drivers/usb/chipidea/debug.c
@@ -322,8 +322,10 @@ static ssize_t ci_role_write(struct file
return -EINVAL;

+ disable_irq(ci->irq);
ret = ci_role_start(ci, role);
+ enable_irq(ci->irq);

return ret ? ret : count;

 \ /
  Last update: 2015-12-07 16:21    [W:0.382 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site