lkml.org 
[lkml]   [2015]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.1 95/95] KVM: s390: enable SIMD only when no VCPUs were created
    Date
    4.1-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: David Hildenbrand <dahi@linux.vnet.ibm.com>

    commit 5967c17b118a2bd1dd1d554cc4eee16233e52bec upstream.

    We should never allow to enable/disable any facilities for the guest
    when other VCPUs were already created.

    kvm_arch_vcpu_(load|put) relies on SIMD not changing during runtime.
    If somebody would create and run VCPUs and then decides to enable
    SIMD, undefined behaviour could be possible (e.g. vector save area
    not being set up).

    Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
    Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    Signed-off-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
    Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/s390/kvm/kvm-s390.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    --- a/arch/s390/kvm/kvm-s390.c
    +++ b/arch/s390/kvm/kvm-s390.c
    @@ -283,12 +283,16 @@ static int kvm_vm_ioctl_enable_cap(struc
    r = 0;
    break;
    case KVM_CAP_S390_VECTOR_REGISTERS:
    - if (MACHINE_HAS_VX) {
    + mutex_lock(&kvm->lock);
    + if (atomic_read(&kvm->online_vcpus)) {
    + r = -EBUSY;
    + } else if (MACHINE_HAS_VX) {
    set_kvm_facility(kvm->arch.model.fac->mask, 129);
    set_kvm_facility(kvm->arch.model.fac->list, 129);
    r = 0;
    } else
    r = -EINVAL;
    + mutex_unlock(&kvm->lock);
    break;
    case KVM_CAP_S390_USER_STSI:
    kvm->arch.user_stsi = 1;



    \
     
     \ /
      Last update: 2015-12-07 16:01    [W:4.085 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site