lkml.org 
[lkml]   [2015]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] x86/cpufeature: Remove unused and seldomly used cpu_has_xx macros

* Borislav Petkov <bp@alien8.de> wrote:

> On Mon, Dec 07, 2015 at 10:45:04AM +0100, Ingo Molnar wrote:
> >
> > * Borislav Petkov <bp@alien8.de> wrote:
> >
> > > static int __init chacha20_simd_mod_init(void)
> > > {
> > > - if (!cpu_has_ssse3)
> > > + if (!boot_cpu_has(X86_FEATURE_SSSE3))
> > > return -ENODEV;
> >
> > Btw., could we rename 'boot_cpu_has()' to the more appropriate (and shorter!)
> > 'system_has()' form?
> >
> > 'boot cpu' is a conceptual misnomer here really: it's just an implementational
> > detail that we are looking at the boot CPU's flags, what we really mean to express
> > is that these are system-wide features with no per-cpu properties.
> >
> > Agreed?
>
> Yeah, sounds good to me.
>
> Mind if I do it for the next part of the cleanup, though, and not rework
> those patches which are already tested?

Sure!

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-12-07 15:01    [W:0.041 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site