Messages in this thread | | | Date | Mon, 7 Dec 2015 10:45:04 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 3/4] x86/cpufeature: Remove unused and seldomly used cpu_has_xx macros |
| |
* Borislav Petkov <bp@alien8.de> wrote:
> static int __init chacha20_simd_mod_init(void) > { > - if (!cpu_has_ssse3) > + if (!boot_cpu_has(X86_FEATURE_SSSE3)) > return -ENODEV;
Btw., could we rename 'boot_cpu_has()' to the more appropriate (and shorter!) 'system_has()' form?
'boot cpu' is a conceptual misnomer here really: it's just an implementational detail that we are looking at the boot CPU's flags, what we really mean to express is that these are system-wide features with no per-cpu properties.
Agreed?
Thanks,
Ingo
| |