lkml.org 
[lkml]   [2015]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] cpumask: Migrate 'alloc_cpumask_var()' users to 'zalloc_cpumask_var()'

* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Mon, Dec 7, 2015 at 12:49 AM, Ingo Molnar <mingo@kernel.org> wrote:
> > Xunlei Pang reported a scheduler bug in init_rootdomain(), which is
> > caused by improper use of alloc_cpumask_var(), which results in
> > uninitialized cpumasks being allocated.
> >
> > No-one noticed this scheduler bug for a long time, probably because
> > alloc_cpumask_var() does result in initialized cpumasks in the
> > !CPUMASK_OFFSTACK case - which is the vast majority of systems
> > out there.
> >
> > So migrate all alloc_cpumask_var() users over to zalloc_cpumask_var(), to be
> > on the safe side.
>
> Ugh. I'd rather just see us say that "allocating a cpumask always returns a
> zeroed mask".
>
> There really is no reason to ever not zero it (they aren't _that_ big even on
> huge machines), so I'd rather just get rid of the "zalloc" version that is the
> less common one anyway.

Sure - that was my original suggestion, will reshape the series to do it like
that.

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-12-08 05:41    [W:0.065 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site