lkml.org 
[lkml]   [2015]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [BUG] checkpatch: unescaped left brace in regex is deprecated
From
2015-12-07 20:06 GMT-03:00 Joe Perches <joe@perches.com>:
> On Mon, 2015-12-07 at 19:53 -0300, Geyslan G. Bem wrote:
>> Hello,
>
> hello.
>
>> Follow checkpatch output using perl 5.22.0.
>>
>> geyslan@hb ~/Projects/linux $ scripts/checkpatch.pl -f
>> drivers/usb/host/ehci-hub.c
>> Unescaped left brace in regex is deprecated, passed through in regex;
>> marked by <-- HERE in m/\((?^x:
>>
>
> No HERE here. Are you using linux-next?
Yep,

geyslan@hb ~/Projects/linux $ git branch -a
* (HEAD detached from linux-next/master)
...

geyslan@hb ~/Projects/linux $ git remote update
Fetching linux
Fetching linux-next
Fetching linux-staging

>
> There have been patches applied for this warning already.
>
> see:
>
> commit 4e5d56bdf892e18832a6540b63ebf709966bce2a
> Author: Eddie Kovsky <ewk@edkovsky.org>
> Date: Wed Sep 9 15:37:52 2015 -0700
>
> checkpatch: fix left brace warning
>
> Using checkpatch.pl with Perl 5.22.0 generates the following warning:
>
> Unescaped left brace in regex is deprecated, passed through in regex;
> 5.

Indeed. But here the error continues.

geyslan@hb ~/Projects/linux $ git log 4e5d56bdf892e -1
commit 4e5d56bdf892e18832a6540b63ebf709966bce2a
Author: Eddie Kovsky <ewk@edkovsky.org>
Date: Wed Sep 9 15:37:52 2015 -0700

checkpatch: fix left brace warning

Using checkpatch.pl with Perl 5.22.0 generates the following warning:
...

geyslan@hb ~/Projects/linux $ git blame scripts/checkpatch.pl | grep 4e5d56b
3599:4e5d56bdf89 (Eddie Kovsky 2015-09-09 15:37:52 -0700
3599) !($line=~/\#\s*define.*do\s\{/) and !($line=~/}/)) {
4111:4e5d56bdf89 (Eddie Kovsky 2015-09-09 15:37:52 -0700
4111) if (($line =~ /\(.*\)\{/ && $line !~ /\($Type\){/) ||
4112:4e5d56bdf89 (Eddie Kovsky 2015-09-09 15:37:52 -0700
4112) $line =~ /do\{/) {
4589:4e5d56bdf89 (Eddie Kovsky 2015-09-09 15:37:52 -0700
4589) $dstat !~ /^\(\{/ && # ({...

It missed some regexes, maybe?

--
Regards,

Geyslan G. Bem
hackingbits.com


\
 
 \ /
  Last update: 2015-12-08 01:01    [W:0.061 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site