Messages in this thread | | | Subject | Re: [RFC PATCH -v2] mm, oom: introduce oom reaper | From | Tetsuo Handa <> | Date | Tue, 8 Dec 2015 07:19:42 +0900 |
| |
Michal Hocko wrote: > Yes you are right! The reference count should be incremented before > publishing the new mm_to_reap. I thought that an elevated ref. count by > the caller would be enough but this was clearly wrong. Does the update > below looks better?
I think that moving mmdrop() from oom_kill_process() to oom_reap_vmas() xor wake_oom_reaper() makes the patch simpler.
rcu_read_unlock();
+ if (can_oom_reap) + wake_oom_reaper(mm); /* will call mmdrop() */ + else + mmdrop(mm); - mmdrop(mm); put_task_struct(victim); }
| |