Messages in this thread Patch in this message | | | From | 平松雅巳 / HIRAMATU,MASAMI <> | Subject | RE: [PATCH resend] perf machine: Pass correct string to dso__adjust_kmod_long_name | Date | Mon, 7 Dec 2015 03:33:53 +0000 |
| |
>From: Wang Nan [mailto:wangnan0@huawei.com] > >There's a mistake in dso__adjust_kmod_long_name() that, it use strdup() >to dup the new long_name of a dso, but passes the original string >to dso__set_long_name(). Which causes random crash during cleanup. >
Looks good to me:)
Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Thanks!
>Fixes: c03d5184f0e9("perf machine: Adjust dso->long_name for offline module") >Signed-off-by: Wang Nan <wangnan0@huawei.com> >Cc: Arnaldo Carvalho de Melo <acme@redhat.com> >Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> >Cc: Namhyung Kim <namhyung@kernel.org> >Cc: Zefan Li <lizefan@huawei.com> >Cc: pi3orama@163.com >--- > tools/perf/util/machine.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c >index 95a7f60..bfc289c 100644 >--- a/tools/perf/util/machine.c >+++ b/tools/perf/util/machine.c >@@ -576,7 +576,7 @@ static void dso__adjust_kmod_long_name(struct dso *dso, const char *filename) > if (!dup_filename) > return; > >- dso__set_long_name(dso, filename, true); >+ dso__set_long_name(dso, dup_filename, true); > } > > struct map *machine__findnew_module_map(struct machine *machine, u64 start, >-- >1.8.3.4
| |