lkml.org 
[lkml]   [2015]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH LINUX v4 07/13] tty: xuartps: Keep lock for whole ISR
    Date
    The RX path in the interrupt handler released a lock unnecessarily.

    Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
    Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
    ---
    drivers/tty/serial/xilinx_uartps.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
    index 1e9053656610..62224a58056b 100644
    --- a/drivers/tty/serial/xilinx_uartps.c
    +++ b/drivers/tty/serial/xilinx_uartps.c
    @@ -265,9 +265,7 @@ static irqreturn_t cdns_uart_isr(int irq, void *dev_id)
    uart_insert_char(port, isrstatus, CDNS_UART_IXR_OVERRUN,
    data, status);
    }
    - spin_unlock(&port->lock);
    tty_flip_buffer_push(&port->state->port);
    - spin_lock(&port->lock);
    }

    /* Dispatch an appropriate handler */
    --
    2.6.3.3.g9bb996a


    \
     
     \ /
      Last update: 2015-12-06 06:01    [W:7.861 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site