Messages in this thread | | | Date | Sat, 5 Dec 2015 11:22:58 -0500 | From | Johannes Weiner <> | Subject | Re: [PATCH] mm/memcontrol.c: use list_{first,next}_entry |
| |
On Sat, Dec 05, 2015 at 10:55:42AM +0800, Geliang Tang wrote: > On Thu, Dec 03, 2015 at 05:27:18PM +0100, Michal Hocko wrote: > > On Thu 03-12-15 22:16:55, Geliang Tang wrote: > > > To make the intention clearer, use list_{first,next}_entry instead > > > of list_entry. > > > > Does this really help readability? This function simply uncharges the > > given list of pages. Why cannot we simply use list_for_each_entry > > instead... > > I have tested it, list_for_each_entry can't work. Dose it mean that my > patch is OK? Or please give me some other advices.
Your patch is okay. Please feel free to add my
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
| |