Messages in this thread | | | From | Julian Calaby <> | Date | Sat, 5 Dec 2015 13:38:03 +1100 | Subject | Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips |
| |
Hi Finn,
On Sat, Dec 5, 2015 at 1:12 PM, Finn Thain <fthain@telegraphics.com.au> wrote: > > On Sat, 5 Dec 2015, Julian Calaby wrote: > >> Hi Finn, >> >> On Fri, Dec 4, 2015 at 7:38 PM, Finn Thain <fthain@telegraphics.com.au> wrote: >> > >> > On Fri, 4 Dec 2015, Julian Calaby wrote: >> > >> >> > - if (overrides[current_override].board == BOARD_NCR53C400A) { >> >> > + if (overrides[current_override].board == BOARD_NCR53C400A || >> >> > + overrides[current_override].board == BOARD_DTC3181E) { >> >> >> >> These if statements are starting to get a bit long, would it make >> >> sense to replace them with a flag or equivalent? >> > >> > To what end? Shorter lines? As in, >> >> Pretty much, each expression is quite long and they seem to be growing >> fairly rapidly as you and Ondrej discover similar boards. > > Each BOARD_* macro actually refers to a whole category of devices. No new > boards, devices or categories of devices have been discovered. > > Ondrej is enabling and/or fixing PDMA functionality for three existing > device categories, for which the driver already has a nominally compatible > PDMA implementation.
I meant discovering boards which are similar.
Either way, I'm not sure it matters that much.
Thanks,
-- Julian Calaby
Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/
| |