Messages in this thread | | | Date | Fri, 4 Dec 2015 17:03:17 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] memcg, vmscan: Do not wait for writeback if killed |
| |
On Thu, 3 Dec 2015 10:08:26 +0100 Michal Hocko <mhocko@kernel.org> wrote:
> So you think a comment would be sufficient? > --- > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 98a1934493af..2e8ee9e5fcb5 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1031,9 +1031,12 @@ static unsigned long shrink_page_list(struct list_head *page_list, > /* > * We've got killed while waiting here so > * expedite our way out from the reclaim > + * > + * Our callers should make sure we do not > + * get here with fatal signals again. > */
Seems OK. s/should/must/
Please resend it all after the usual exhaustive testing ;)
| |