Messages in this thread | | | Date | Fri, 4 Dec 2015 09:11:27 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC allocation |
| |
> >> if (unlikely(!ring_header->desc)) { > >> - dev_err(&pdev->dev, "pci_alloc_consistend failed\n"); > >> + dev_err(&pdev->dev, "could not get memory for DMA buffer\n"); > >> goto err_nomem; > >> } > >> memset(ring_header->desc, 0, ring_header->size); > >> > >> > > > > So this memset() will really require a different patch to get removed ? > > > > Sigh, not sure why I review patches. > > Agreed, please use dma_zalloc_coherent() and kill that memset().
Ok, updated. I'll also add cc: stable, because it makes notebooks with affected chipset unusable.
Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |