Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH v7 2/6] mfd: syscon: add a DT property to set value width | Date | Fri, 04 Dec 2015 17:02:53 +0100 |
| |
On Wednesday 02 December 2015 18:21:02 Damien Riegel wrote: > Lee, Arnd, > > I had to make changes in this patch to address Rob's comments. > reg-io-width is now in bytes while bus-width was a value in bits. Could > you please review this patch ?
Ok, that's fine.
> > On Mon, Nov 30, 2015 at 01:00:15PM -0600, Rob Herring wrote: > > On Mon, Nov 30, 2015 at 10:59:47AM -0500, Damien Riegel wrote: > > > Currently syscon has a fixed configuration of 32 bits for register and > > > values widths. In some cases, it would be desirable to be able to > > > customize the value width. > > > > > > For example, certain boards (like the ones manufactured by Technologic > > > Systems) have a FPGA that is memory-mapped, but its registers are only > > > 16-bit wide. > > > > > > This patch adds an optional "reg-io-width" DT binding for syscon that > > > allows to change the width for the data bus (i.e. val_bits). If this > > > property is provided, it will also set the register stride to > > > reg-io-width's value. If not provided, the default configuration is > > > used. > > > > > > Signed-off-by: Damien Riegel <damien.riegel@savoirfairelinux.com> > > > > Acked-by: Rob Herring <robh@kernel.org> > > >
Acked-by: Arnd Bergmann <arnd@arndb.de>
| |