lkml.org 
[lkml]   [2015]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] trace-cmd: quiet some output when using libtracecmd
Date
If you link against libtracecmd you get a few extraneous warnings and printf's
that aren't related to your tool. So by default make the path to the events you
are tracing use pr_stat() so if it's not defined we don't get the output, and
make the weak warning() do nothing by default. The trace-cmd stuff has this
defined so it'll continue to work normally, it just won't be noisy for consumers
of libtracecmd. Thanks,

Signed-off-by: Josef Bacik <jbacik@fb.com>
---
parse-utils.c | 5 -----
trace-record.c | 2 +-
2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/parse-utils.c b/parse-utils.c
index c5b0487..9f9c0e9 100644
--- a/parse-utils.c
+++ b/parse-utils.c
@@ -63,11 +63,6 @@ void __warning(const char *fmt, ...)

void __weak warning(const char *fmt, ...)
{
- va_list ap;
-
- va_start(ap, fmt);
- __vwarning(fmt, ap);
- va_end(ap);
}

void __vpr_stat(const char *fmt, va_list ap)
diff --git a/trace-record.c b/trace-record.c
index e4194b5..7d3ea37 100644
--- a/trace-record.c
+++ b/trace-record.c
@@ -2120,7 +2120,7 @@ static int expand_event_files(struct buffer_instance *instance,
path = globbuf.gl_pathv[i];

event = create_event(instance, path, old_event);
- printf("%s\n", path);
+ pr_stat("%s\n", path);

len = strlen(path);

--
2.5.0


\
 
 \ /
  Last update: 2015-12-04 16:41    [W:0.036 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site