lkml.org 
[lkml]   [2015]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 6/9] dmaengine:pl330: set segment_boundary_mask = 0cffffffff
    From
    Date
    On 04/12/15 03:24, Wang Hongcheng wrote:
    > Because amd iommu and software iommu need this mask.For example,
    > if we use software iommu without this mask, we will
    > get 'Out of SW-IOMMU space' error, when calling swiotlb_map_page
    > function.

    The commit title doesn't match the code, but either way this patch
    should now be unnecessary: 002edb6f6f2a ("dma-mapping: tidy up dma_parms
    default handling") resolves the problem at its source, and is already in
    4.4-rc1.

    (Incidentally, it was specifically the same PL330/SWIOTLB combination
    that led to that patch in the first place)

    Robin.

    > Signed-off-by: Wan Zongshun <Vincent.Wan@amd.com>
    > Signed-off-by: Wang Hongcheng <annie.wang@amd.com>
    > ---
    > drivers/dma/pl330.c | 4 ++++
    > 1 file changed, 4 insertions(+)
    >
    > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
    > index 9d7af0d..fb46fdf 100644
    > --- a/drivers/dma/pl330.c
    > +++ b/drivers/dma/pl330.c
    > @@ -2966,6 +2966,10 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id)
    > if (ret)
    > dev_err(&adev->dev, "unable to set the seg size\n");
    >
    > + dev_info(&adev->dev, "set the seg boundary\n");
    > + ret = dma_set_seg_boundary(&adev->dev, 0xffffffff);
    > + if (ret)
    > + dev_err(&adev->dev, "unable to set the seg boundary\n");
    >
    > dev_info(&adev->dev,
    > "Loaded driver for PL330 DMAC-%x\n", adev->periphid);
    >



    \
     
     \ /
      Last update: 2015-12-04 16:21    [W:4.084 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site