lkml.org 
[lkml]   [2015]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 3/9] drm/vc4: Add create and map BO ioctls.
    From
    Hi Eric,

    A couple of suggestions/requests on the UAPI header side

    On 1 December 2015 at 20:35, Eric Anholt <eric@anholt.net> wrote:

    > --- /dev/null
    > +++ b/include/uapi/drm/vc4_drm.h

    > +#include <drm/drm.h>
    > +
    Can we make this a "drm.h" ?


    > +struct drm_vc4_create_bo {
    > + uint32_t size;
    > + uint32_t flags;
    > + /** Returned GEM handle for the BO. */
    > + uint32_t handle;
    > + uint32_t pad;
    ... and not use the stdint.h types but __{s,u}* through the file.

    I'd rather than not nag why we want/need those, but if you prefer I
    can repeat myself/others.

    Thanks
    Emil


    \
     
     \ /
      Last update: 2015-12-04 15:41    [W:2.673 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site