Messages in this thread | | | Date | Fri, 4 Dec 2015 14:29:34 +0000 | Subject | Re: [PATCH 3/9] drm/vc4: Add create and map BO ioctls. | From | Emil Velikov <> |
| |
Hi Eric,
A couple of suggestions/requests on the UAPI header side
On 1 December 2015 at 20:35, Eric Anholt <eric@anholt.net> wrote:
> --- /dev/null > +++ b/include/uapi/drm/vc4_drm.h
> +#include <drm/drm.h> > + Can we make this a "drm.h" ?
> +struct drm_vc4_create_bo { > + uint32_t size; > + uint32_t flags; > + /** Returned GEM handle for the BO. */ > + uint32_t handle; > + uint32_t pad; ... and not use the stdint.h types but __{s,u}* through the file.
I'd rather than not nag why we want/need those, but if you prefer I can repeat myself/others.
Thanks Emil
| |