Messages in this thread | | | Date | Fri, 4 Dec 2015 15:17:04 +0100 | From | Petr Mladek <> | Subject | Re: [PATCH v4] livepatch: Cleanup module page permission changes |
| |
On Thu 2015-12-03 16:33:26, Josh Poimboeuf wrote: > Calling set_memory_rw() and set_memory_ro() for every iteration of the > loop in klp_write_object_relocations() is messy, inefficient, and > error-prone. > > Change all the read-only pages to read-write before the loop and convert > them back to read-only again afterwards. > > Suggested-by: Miroslav Benes <mbenes@suse.cz> > Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
This patch looks fine to me.
Reviewed-by: Petr Mladek <pmladek@suse.com>
Thanks, Petr
| |