Messages in this thread | | | Date | Fri, 4 Dec 2015 11:11:44 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH v6] sched/deadline: fix earliest_dl.next logic |
| |
On Fri, Dec 04, 2015 at 09:59:52AM +0000, Juri Lelli wrote: > > + if (next_node) > > + dl_rq->earliest_dl.next = rb_entry(next_node, > > + struct task_struct, pushable_dl_tasks)->dl.deadline; > > Small nitpick, we are breaking 80 columns here, checkpatch should have > complained. I guess a different indentation could help. > > Apart from this, I couldn't spot any more problems with this patch.
So I don't mind the occasional violation of that rule if it aids in better readable code.
However, that should now have included {} because the statement is multi-line. Coding style suggests we have braces for anything over 1 line. I'll make that edit when applying, no need to resend yet another time :-)
> Acked-by: Juri Lelli <juri.lelli@arm.com>
Thanks, I'll try and get it queued later today.
| |