| Date | Fri, 4 Dec 2015 20:20:13 +1100 (AEDT) | From | Finn Thain <> | Subject | Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips |
| |
On Fri, 4 Dec 2015, Ondrej Zary wrote:
> @@ -685,8 +684,10 @@ static inline int NCR5380_pwrite(struct Scsi_Host *instance, unsigned char *src, > /* All documentation says to check for this. Maybe my hardware is too > * fast. Waiting for it seems to work fine! KLL > */ > - while (!(i = NCR5380_read(hostdata->c400_ctl_status) & CSR_GATED_53C80_IRQ)) > + while (!(i = NCR5380_read(hostdata->c400_ctl_status) & CSR_GATED_53C80_IRQ)) { > + udelay(4); /* DTC436 chip hangs without this */ > ; // FIXME - no timeout > + } > > /* > * I know. i is certainly != 0 here but the loop is new. See previous >
Given that you've added braces, the redundant semicolon can be removed.
--
|