Messages in this thread | | | Date | Thu, 3 Dec 2015 17:08:21 +0000 | From | Mark Rutland <> | Subject | Re: [PATCH v2 2/6] arm64: Move kill_cpu_early to smp.c |
| |
On Thu, Dec 03, 2015 at 04:36:51PM +0000, Suzuki K. Poulose wrote: > On 01/12/15 18:50, Mark Rutland wrote: > >On Tue, Dec 01, 2015 at 06:10:17PM +0000, Suzuki K. Poulose wrote: > >>On 01/12/15 17:52, Mark Rutland wrote: > >>>On Tue, Dec 01, 2015 at 05:38:54PM +0000, Suzuki K. Poulose wrote: > >>>>On 01/12/15 16:31, Mark Rutland wrote: > >>OK. So the flag will also be used for CPUs which are stuck-in-the-kernel > >>with MMU turned on. e.g, a CPU (using spin-table) we try to bring down > >>in kill_cpu_early(). Correct ? > > > >Yes. > > > >We'd also pad it such that nothing else shares the same writeback > >granule, and when writing to it with the MMU off we can invalidate the > >stale cached copy. > > I have started working on this approach. But the changes are a bit more invasive > and looks more like suited for 4.5. We could push this series(which doesn't change > the current behavior as it is in 4.4-rc3, except for the code movement) to fix > the ASID sanity check and introduce the synchronisation part in 4.5. > What do you think ?
I'm happy with that. I agree this patch as-is doesn't make matters worse.
Thanks, Mark.
| |