lkml.org 
[lkml]   [2015]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] leds: sunfire: Use platform_register/unregister_drivers()
On 12/02/2015 05:27 PM, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> These new helpers simplify implementing multi-driver modules and
> properly handle failure to register one driver by unregistering all
> previously registered drivers.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/leds/leds-sunfire.c | 23 +++++++----------------
> 1 file changed, 7 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/leds/leds-sunfire.c b/drivers/leds/leds-sunfire.c
> index c2553c54f2cf..7c09db8bd4e8 100644
> --- a/drivers/leds/leds-sunfire.c
> +++ b/drivers/leds/leds-sunfire.c
> @@ -234,28 +234,19 @@ static struct platform_driver sunfire_fhc_led_driver = {
> },
> };
>
> +static struct platform_driver * const drivers[] = {
> + &sunfire_clockboard_led_driver,
> + &sunfire_fhc_led_driver,
> +};
> +
> static int __init sunfire_leds_init(void)
> {
> - int err = platform_driver_register(&sunfire_clockboard_led_driver);
> -
> - if (err) {
> - pr_err("Could not register clock board LED driver\n");
> - return err;
> - }
> -
> - err = platform_driver_register(&sunfire_fhc_led_driver);
> - if (err) {
> - pr_err("Could not register FHC LED driver\n");
> - platform_driver_unregister(&sunfire_clockboard_led_driver);
> - }
> -
> - return err;
> + return platform_register_drivers(drivers, ARRAY_SIZE(drivers));
> }
>
> static void __exit sunfire_leds_exit(void)
> {
> - platform_driver_unregister(&sunfire_clockboard_led_driver);
> - platform_driver_unregister(&sunfire_fhc_led_driver);
> + platform_unregister_drivers(drivers, ARRAY_SIZE(drivers));
> }
>
> module_init(sunfire_leds_init);
>

Applied, thanks.

--
Best Regards,
Jacek Anaszewski


\
 
 \ /
  Last update: 2015-12-03 12:01    [W:0.030 / U:1.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site