lkml.org 
[lkml]   [2015]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] [media] hdpvr: Refactoring for hdpvr_read()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Tue, 29 Dec 2015 11:02:43 +0100

    Let us return directly if the element "status" of the variable "buf"
    indicates "BUFSTAT_READY".
    A check repetition can be excluded for the variable "ret" at the end then.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/media/usb/hdpvr/hdpvr-video.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/media/usb/hdpvr/hdpvr-video.c b/drivers/media/usb/hdpvr/hdpvr-video.c
    index 7dee22d..ba7f022 100644
    --- a/drivers/media/usb/hdpvr/hdpvr-video.c
    +++ b/drivers/media/usb/hdpvr/hdpvr-video.c
    @@ -462,10 +462,8 @@ static ssize_t hdpvr_read(struct file *file, char __user *buffer, size_t count,
    }

    if (wait_event_interruptible(dev->wait_data,
    - buf->status == BUFSTAT_READY)) {
    - ret = -ERESTARTSYS;
    - goto err;
    - }
    + buf->status == BUFSTAT_READY))
    + return -ERESTARTSYS;
    }

    if (buf->status != BUFSTAT_READY)
    --
    2.6.3


    \
     
     \ /
      Last update: 2015-12-29 12:01    [W:4.020 / U:0.396 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site