Messages in this thread | | | Date | Wed, 30 Dec 2015 09:28:06 +0900 | From | Chanwoo Choi <> | Subject | Re: [PATCH] extcon: arizona: Use DAPM mutex helper functions |
| |
On 2015년 12월 30일 01:32, Charles Keepax wrote: > We should be using the helper functions to lock the DAPM mutex not > accessing it directly. There are no ill effects of this as the moment > but it is best practice, and the implementation could be changed in the > future. > > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> > --- > drivers/extcon/extcon-arizona.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c > index c121d01..1d8e0a5 100644 > --- a/drivers/extcon/extcon-arizona.c > +++ b/drivers/extcon/extcon-arizona.c > @@ -185,7 +185,7 @@ static void arizona_extcon_hp_clamp(struct arizona_extcon_info *info, > break; > }; > > - mutex_lock(&arizona->dapm->card->dapm_mutex); > + snd_soc_dapm_mutex_lock(arizona->dapm); > > arizona->hpdet_clamp = clamp; > > @@ -227,7 +227,7 @@ static void arizona_extcon_hp_clamp(struct arizona_extcon_info *info, > ret); > } > > - mutex_unlock(&arizona->dapm->card->dapm_mutex); > + snd_soc_dapm_mutex_unlock(arizona->dapm); > } > > static void arizona_extcon_set_mode(struct arizona_extcon_info *info, int mode) >
Looks good to me. Applied it.
Thanks, Chanwoo Choi
| |