Messages in this thread | | | Subject | Re: [RESEND PATCH v1 3/4] net: ethernet: arc: Add support emac for RK3036 | From | Florian Fainelli <> | Date | Tue, 29 Dec 2015 14:59:59 -0800 |
| |
On December 27, 2015 11:22:20 PM PST, Xing Zheng <zhengxing@rock-chips.com> wrote: >The RK3036's GRFs offset are different with RK3066/RK3188, and need to >set >mac TX/RX clock before probe emac. > >Signed-off-by: Xing Zheng <zhengxing@rock-chips.com> >--- <snip> > }; > > static const struct of_device_id emac_rockchip_dt_ids[] = { >- { .compatible = "rockchip,rk3066-emac", .data = >&emac_rockchip_dt_data[0] }, >- { .compatible = "rockchip,rk3188-emac", .data = >&emac_rockchip_dt_data[1] }, >+ { .compatible = "rockchip,rk3036-emac", .data = >&emac_rockchip_dt_data[0] }, >+ { .compatible = "rockchip,rk3066-emac", .data = >&emac_rockchip_dt_data[1] }, >+ { .compatible = "rockchip,rk3188-emac", .data = >&emac_rockchip_dt_data[2] }, > { /* Sentinel */ }
Food for thought, you might want to use an enum here to index emac_rockchip_dt_data which would be less error prone if you add/remove entries in this structure.
-- Florian
| |