Messages in this thread Patch in this message | | | From | Insu Yun <> | Subject | [PATCH] cx231xx: correctly handling failed allocation | Date | Tue, 29 Dec 2015 13:53:35 -0500 |
| |
Since kmalloc can be failed in memory pressure, if not properly handled, NULL dereference can be happend
Signed-off-by: Insu Yun <wuninsu@gmail.com> --- drivers/media/usb/cx231xx/cx231xx-417.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/media/usb/cx231xx/cx231xx-417.c b/drivers/media/usb/cx231xx/cx231xx-417.c index 47a98a2..9725e4f 100644 --- a/drivers/media/usb/cx231xx/cx231xx-417.c +++ b/drivers/media/usb/cx231xx/cx231xx-417.c @@ -1382,6 +1382,8 @@ static int cx231xx_bulk_copy(struct cx231xx *dev, struct urb *urb) buffer_size = urb->actual_length; buffer = kmalloc(buffer_size, GFP_ATOMIC); + if (!buffer) + return -ENOMEM; memcpy(buffer, dma_q->ps_head, 3); memcpy(buffer+3, p_buffer, buffer_size-3); -- 1.9.1
| |