lkml.org 
[lkml]   [2015]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 2/3] device property: the secondary fwnode needs to depend on the primary
From
Date
On Tue, 2015-12-29 at 10:40 +0200, Heikki Krogerus wrote:
> Hi Andy,
>
> Found a bug from my code..
>
> > diff --git a/drivers/base/property.c b/drivers/base/property.c
> > index 0b22c8a..6c04d18 100644
> > --- a/drivers/base/property.c
> > +++ b/drivers/base/property.c
> > @@ -218,7 +218,7 @@ bool fwnode_property_present(struct
> > fwnode_handle *fwnode, const char *propname)
> >   bool ret;
> >  
> >   ret = __fwnode_property_present(fwnode, propname);
> > - if (ret == false && fwnode->secondary)
> > + if (ret == false && fwnode && fwnode->secondary)
> >   ret = __fwnode_property_present(fwnode->secondary,
> > propname);
> >   return ret;
> >  }
> > @@ -423,7 +423,7 @@
> > EXPORT_SYMBOL_GPL(device_property_match_string);
> >   int _ret_;
> > \
> >   _ret_ = FWNODE_PROP_READ(_fwnode_, _propname_, _type_,
> > _proptype_, \
> >    _val_, _nval_);
> > \
> > - if (_ret_ == -EINVAL && _fwnode_->secondary)
> > \
> > + if (_ret_ == -EINVAL && fwnode && _fwnode_->secondary)
> > \
>
> This should be .._fwnode_ && _fwnode_->secondary)

Yeah, we compiled it correctly due to fwnode presents in all
occurrences of this macro.

I will fix and resend a new version.

>
> >   _ret_ = FWNODE_PROP_READ(_fwnode_->secondary,
> > _propname_, _type_, \
> >   _proptype_, _val_, _nval_);
> > \
> >   _ret_;
> > \
>
>
> Cheers,
>

--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy



\
 
 \ /
  Last update: 2015-12-29 12:21    [W:0.134 / U:1.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site