lkml.org 
[lkml]   [2015]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/8] perf script: Add stat default handlers
On Wed, Dec 23, 2015 at 10:40:38PM +0900, Namhyung Kim wrote:
> On Tue, Dec 22, 2015 at 04:43:31PM +0100, Jiri Olsa wrote:
> > Implement struct scripting_ops::(process_stat|process_stat_interval)
> > handlers - calling scripting handlers from stat events handlers.
> >
> > Tested-by: Kan Liang <kan.liang@intel.com>
> > Link: http://lkml.kernel.org/n/tip-3iu6vmvuur1bntbnh43v3bib@git.kernel.org
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > ---
> > tools/perf/builtin-script.c | 33 +++++++++++++++++++++++++++++++++
> > 1 file changed, 33 insertions(+)
> >
> > diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> > index a90bc0b81e70..656541eff151 100644
> > --- a/tools/perf/builtin-script.c
> > +++ b/tools/perf/builtin-script.c
> > @@ -221,6 +221,9 @@ static int perf_evsel__check_attr(struct perf_evsel *evsel,
> > struct perf_event_attr *attr = &evsel->attr;
> > bool allow_user_set;
> >
> > + if (perf_header__has_feat(&session->header, HEADER_STAT))
> > + return 0;
> > +
> > allow_user_set = perf_header__has_feat(&session->header,
> > HEADER_AUXTRACE);
> >
> > @@ -674,6 +677,18 @@ static void process_event(struct perf_script *script __maybe_unused, union perf_
> >
> > static struct scripting_ops *scripting_ops;
> >
> > +static void process_stat(struct perf_evsel *counter, u64 time)
> > +{
> > + if (scripting_ops)
> > + scripting_ops->process_stat(&stat_config, counter, time);
>
> Shouldn't it be
>
> if (scripting_ops && scripting_ops->process_stat)
>
> ? It seems you only set it for python in patch 7..

right.. forgot about perf completely..

thanks,
jirka


\
 
 \ /
  Last update: 2015-12-23 17:21    [W:0.058 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site