lkml.org 
[lkml]   [2015]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/5] watchdog: Separate and maintain variables based on variable lifetime
From
Date
On 12/22/2015 02:05 PM, Tomas Winkler wrote:

>
> > Do you see a situation where holding the lock between calls into the driver
> > might be a problem ?
>
> I don't think u are holding the lock now in watchdog_unregister when WDOG_UNREGISTERED was dropped.

the lock is held while clearing the pointers:

mutex_lock(&wd_data->lock);
wd_data->wdd = NULL;
wdd->wd_data = NULL;
mutex_unlock(&wd_data->lock);

Guenter



\
 
 \ /
  Last update: 2015-12-23 02:01    [W:0.319 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site