lkml.org 
[lkml]   [2015]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC PATCH 2/5] crypto: sunxi-ss: fix min3() call to match types
Date
On Tuesday 22 December 2015, Andre Przywara wrote:
> The min3() macro expects all arguments to be of the same type (or
> size at least). While two arguments are ints or u32s, one is size_t,
> which does not match on 64-bit architectures.
> Cast the size_t to u32 to make min3() happy. In this context here the
> length should never exceed 32 bits anyway.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>

Looks correct, but a bit ugly. Could we avoid the casts by using
temporary variables to keep the size_t based data?

Arnd


\
 
 \ /
  Last update: 2015-12-22 23:21    [W:0.111 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site