Messages in this thread | | | Subject | Re: [PATCH 1/2] usb: gadget: f_midi: refactor state machine | From | Clemens Ladisch <> | Date | Tue, 22 Dec 2015 18:10:39 +0100 |
| |
Felipe F. Tonello wrote: > This refactor includes the following: > * Cleaner state machine code;
It does not correctly handle system real time messages inserted between the status and data bytes of other messages.
> * Reset state if MIDI message parsed is non-conformant;
Why? In a byte stream like "C1 C3 44", where the data byte of the first message was lost, the reset would also drop the second message.
> * Fixed bug when a conformant MIDI message was followed by a non-conformant > causing the MIDI-USB message to use old temporary data (port->data[0..1]), > thus packing a wrong MIDI-USB request.
Running status is feature.
Regards, Clemens
| |