lkml.org 
[lkml]   [2015]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] usb: gadget: f_midi: refactor state machine
From
Date
Felipe F. Tonello wrote:
> This refactor includes the following:
> * Cleaner state machine code;

It does not correctly handle system real time messages inserted between
the status and data bytes of other messages.

> * Reset state if MIDI message parsed is non-conformant;

Why? In a byte stream like "C1 C3 44", where the data byte of the first
message was lost, the reset would also drop the second message.

> * Fixed bug when a conformant MIDI message was followed by a non-conformant
> causing the MIDI-USB message to use old temporary data (port->data[0..1]),
> thus packing a wrong MIDI-USB request.

Running status is feature.


Regards,
Clemens


\
 
 \ /
  Last update: 2015-12-22 18:41    [W:0.088 / U:1.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site