Messages in this thread | | | Date | Tue, 22 Dec 2015 10:29:03 -0500 | From | Dave Goodell <> | Subject | Re: [PATCH] IB/usnic: delete unneeded IS_ERR test |
| |
[copying Nelson too]
On Sat, Dec 19, 2015 at 09:48:59PM +0100, Julia Lawall wrote: > kzalloc doesn't return ERR_PTR, so there is no need to test for it. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression x,e; > @@ > > * x = kzalloc(...) > ... when != x = e > * IS_ERR_OR_NULL(x) > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Dave Goodell <dgoodell@cisco.com>
-Dave
| |