Messages in this thread Patch in this message | | | From | Jon Hunter <> | Subject | [PATCH V2 2/2] irqchip/gic: Only populate set_affinity for the root controller | Date | Tue, 22 Dec 2015 12:09:36 +0000 |
| |
Setting the affinity of an IRQ, it only applicable for the root interrupt controller and so only populate this operator for the root controller.
Signed-off-by: Jon Hunter <jonathanh@nvidia.com> ---
V2 changes: - Fixed compilation error with !SMP
drivers/irqchip/irq-gic.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c index 94ad60c424a7..9df912db4105 100644 --- a/drivers/irqchip/irq-gic.c +++ b/drivers/irqchip/irq-gic.c @@ -384,9 +384,6 @@ static struct irq_chip gic_chip = { .irq_unmask = gic_unmask_irq, .irq_eoi = gic_eoi_irq, .irq_set_type = gic_set_type, -#ifdef CONFIG_SMP - .irq_set_affinity = gic_set_affinity, -#endif .irq_get_irqchip_state = gic_irq_get_irqchip_state, .irq_set_irqchip_state = gic_irq_set_irqchip_state, .flags = IRQCHIP_SET_TYPE_MASKED | @@ -1017,10 +1014,17 @@ static void __init __gic_init_bases(unsigned int gic_nr, int irq_start, gic->chip.name = kasprintf(GFP_KERNEL, "GIC-%d", gic_nr); /* Initialize irq_chip */ - if (static_key_true(&supports_deactivate) && gic_nr == 0) { - gic->chip.irq_mask = gic_eoimode1_mask_irq; - gic->chip.irq_eoi = gic_eoimode1_eoi_irq; - gic->chip.irq_set_vcpu_affinity = gic_irq_set_vcpu_affinity; + if (gic_nr == 0) { +#ifdef CONFIG_SMP + gic->chip.irq_set_affinity = gic_set_affinity; +#endif + + if (static_key_true(&supports_deactivate)) { + gic->chip.irq_mask = gic_eoimode1_mask_irq; + gic->chip.irq_eoi = gic_eoimode1_eoi_irq; + gic->chip.irq_set_vcpu_affinity = + gic_irq_set_vcpu_affinity; + } } #ifdef CONFIG_GIC_NON_BANKED -- 2.1.4
| |