Messages in this thread | | | Date | Tue, 22 Dec 2015 10:58:24 +0100 | Subject | Re: [RFC PATCH V2 1/8] irqdomain: Ensure type settings match for an existing mapping | From | Linus Walleij <> |
| |
On Fri, Dec 18, 2015 at 11:10 AM, Jon Hunter <jonathanh@nvidia.com> wrote: > On 17/12/15 13:16, Linus Walleij wrote: >> On Thu, Dec 17, 2015 at 11:48 AM, Jon Hunter <jonathanh@nvidia.com> wrote: >>> + } else { >>> + virq = irq_domain_alloc_descs(-1, 1, hwirq, >>> + of_node_to_nid(of_node)); >> >> What is this all of a sudden? Not even mentioned in the >> commit. Plus I bet ACPI need something else than OF nid >> passed here. > > Do you mean the else part of all of the above?
Yes
> So in the current code, the else part calls irq_create_mapping() (...)
No, not that... The fact that you all of a sudden have started calling irq_domain_alloc_descs() which the function didn't do before, totally changing the calling semantics for everyone in the kernel, leading to the problem I then describe with this potentially being called before the irqdomain for the irqchip is initialized and descs getting "random" numbers.
Yours, Linus Walleij
| |