lkml.org 
[lkml]   [2015]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] perf, tools, stat: Abstract stat metrics printing
> > -			fprintf(out, "                                   ");
> > + print_metric(ctxp, NULL, NULL, "insn per cycle", 0);
> > }
> > total = avg_stats(&runtime_stalled_cycles_front_stats[ctx][cpu]);
> > total = max(total, avg_stats(&runtime_stalled_cycles_back_stats[ctx][cpu]));
> >
> > + out->new_line(ctxp);
> > if (total && avg) {
> > ratio = total / avg;
> > - fprintf(out, "\n");
>
> you haven't address my first comment in here http://marc.info/?l=linux-kernel&m=144662610723134&w=2

The new_line is always needed because stalled cycles is always printed.

The reason it is always printed is that metric-only needs to see all the
metrics for its column headers. That's why there are else cases
everywhere.


-Andi
--
ak@linux.intel.com -- Speaking for myself only.


\
 
 \ /
  Last update: 2015-12-22 02:41    [W:0.058 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site