Messages in this thread | | | Date | Mon, 21 Dec 2015 17:16:04 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 02/10] perf, tools, stat: Force --per-core mode for .agg-per-core aliases |
| |
On Tue, Dec 15, 2015 at 04:54:18PM -0800, Andi Kleen wrote: > From: Andi Kleen <ak@linux.intel.com> > > When an event alias is used that the kernel marked as .agg-per-core, force > --per-core mode (and also require -a and forbid cgroups or per thread mode). > This in term means, --topdown forces --per-core mode. > > This is needed for TopDown in SMT mode, because it needs to measure > all threads in a core together and merge the values to compute the correct > percentages of how the pipeline is limited. > > We do this if any alias is agg-per-core. > > Add the code to parse the .agg-per-core attributes and propagate > the information to the evsel. Then the main stat code does > the necessary checks and forces per core mode.
please split it into 2 patches: - support .aggr-per-core alias parsing - force --per-core mode for .agg-per-core aliases
thanks, jirka
| |