Messages in this thread | | | Date | Mon, 21 Dec 2015 21:43:27 +0530 | From | Pratyush Anand <> | Subject | Re: [PATCH V5 1/2] watchdog: Use static struct class watchdog_class in stead of pointer |
| |
On 21/12/2015:07:52:59 AM, Guenter Roeck wrote: > On 12/18/2015 08:22 PM, Pratyush Anand wrote: > >On 17/12/2015:06:56:27 AM, Guenter Roeck wrote: > >>On 12/17/2015 04:23 AM, Pratyush Anand wrote: > >>>We need few sysfs attributes to know different status of a watchdog device. > >>>To do that, we need to associate .dev_groups with watchdog_class. So > >>>convert it from pointer to static. > >>>Putting this static struct in watchdog_dev.c, so that static device > >>>attributes defined in that file can be attached to it. > >>> > >>>Signed-off-by: Pratyush Anand <panand@redhat.com> > >>>Suggested-by: Guenter Roeck <linux@roeck-us.net> > >>>Reviewed-by: Guenter Roeck <linux@roeck-us.net> > >> > >>As things evolve, I'd by now prefer to move the call to device_create() > >>into watchdog_dev.c, but that can wait for a follow-up patch if Wim > >>is ok with this series. > > > >Thanks for your quick review. > > > >OK. I will wait for Wim's comment and then may be I will send another > >version with your comment for patch 1/1 incorporated. > > > > Thinking about it, my comment is really minor and should not hold up the > series from going forward. So let's just skip another version unless Wim > or someone else has any comments.
Thanks a lot :-)
~Pratyush
| |