Messages in this thread | | | Subject | Re: [PATCH V2 21/23] pci, acpi: Support for ACPI based PCI hostbridge init | From | Tomasz Nowicki <> | Date | Mon, 21 Dec 2015 11:21:02 +0100 |
| |
On 18.12.2015 13:40, Arnd Bergmann wrote: > On Wednesday 16 December 2015 16:16:31 Tomasz Nowicki wrote: >> Because of two patch series: >> 1. Jiang Liu's common interface to support PCI host bridge init >> 2. MMCONFIG refactoring (part of this patch set) >> now we can think about generic ACPI based PCI host bridge driver >> out of arch/ directory. >> >> This driver use information from MCFG table (PCI config space regions) >> and _CRS method (IO/irq resources) to initialize PCI hostbridge. >> >> TBD: We are still not sure whether we should reassign resources >> after PCI bus enumeration or trust firmware to do all that work for >> us properly. >> >> Signed-off-by: Tomasz Nowicki <tn@semihalf.com> >> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org> >> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> >> CC: Arnd Bergmann <arnd@arndb.de> >> CC: Catalin Marinas <catalin.marinas@arm.com> >> CC: Liviu Dudau <Liviu.Dudau@arm.com> >> CC: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com> >> CC: Will Deacon <will.deacon@arm.com> >> Tested-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> >> > > I think this code could better live in drivers/acpi/pci_root.c > along with all the related functions. It's not really a driver > by itself and cannot be a loadable module or built on other > architectures. > > You can put all the code inside an #ifdef ARCH_PCI_HOST_GENERIC_ACPI > there. >
Makes sense to me, thanks.
Tomasz
| |