lkml.org 
[lkml]   [2015]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 14/19] irqchip/mips-gic: Use gic_vpes instead of NR_CPUS
From
Date
Hello.

On 12/02/2015 03:21 PM, Qais Yousef wrote:

> NR_CPUS is set by Kconfig and could be much higher than what actually is in the
> system.
>
> gic_vpes should be a true representitives of the number of cpus in the system,
> so use it instead.
>
> Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
> ---
> drivers/irqchip/irq-mips-gic.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c
> index 41ccc84c68ba..c24feb739bb3 100644
> --- a/drivers/irqchip/irq-mips-gic.c
> +++ b/drivers/irqchip/irq-mips-gic.c
[...]
> @@ -1084,7 +1084,7 @@ static void __init __gic_init(unsigned long gic_base_addr,
> gic_ipi_domain->bus_token = DOMAIN_BUS_IPI;
>
> /* Make the last 2 * NR_CPUS available for IPIs */

Looks like you forgot to also change this comment...

> - bitmap_set(ipi_resrv, gic_shared_intrs - 2 * NR_CPUS, 2 * NR_CPUS);
> + bitmap_set(ipi_resrv, gic_shared_intrs - 2 * gic_vpes, 2 * gic_vpes);
>
> gic_basic_init();
>

MBR, Sergei



\
 
 \ /
  Last update: 2015-12-02 19:41    [W:0.971 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site