Messages in this thread Patch in this message | | | From | Gregory CLEMENT <> | Subject | Re: [PATCH 00/13] mvneta Buffer Management and enhancements | Date | Wed, 02 Dec 2015 17:21:39 +0100 |
| |
Hi,
On mer., déc. 02 2015, Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:
>> >> So far the issue may have been not noticed, because in every IO driver >> using mvebu_mbus_dram_info for configuring MBUS windows, there's >> following substraction: >> (cs->size - 1) & 0xfffff000 >> >> I think there are two options: >> 1. Change size type to u64. > > If we switch to u64 we really must pay attention to be sure that it > won't be used to be written in a register, but the regsiter remains > 32bits. > >> 2. Change condition in mvebu_mbus_get_dram_win_info to: >> if (cs->base <= phyaddr && phyaddr <= (cs->base + cs->size -1)) > > I think it would be the best solution.
So I applied the following patch: --- a/drivers/bus/mvebu-mbus.c +++ b/drivers/bus/mvebu-mbus.c @@ -964,7 +964,7 @@ int mvebu_mbus_get_dram_win_info(phys_addr_t phyaddr, u8 *target, u8 *attr) for (i = 0; i < dram->num_cs; i++) { const struct mbus_dram_window *cs = dram->cs + i; - if (cs->base <= phyaddr && phyaddr <= (cs->base + cs->size)) { + if (cs->base <= phyaddr && phyaddr <= (cs->base + cs->size - 1)) { *target = dram->mbus_dram_target_id; *attr = cs->mbus_attr; return 0; I didn't get any errors during boot related to the BM. However I did not manage to use an ethernet interface. The udhcpc never managed to get an IP and if I set the IP manually I could not ping.
But on Armada 388 GP I didn't have any issue.
Do you have some idea about waht I could check?
Gregory
-- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
| |