lkml.org 
[lkml]   [2015]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [v8, 2/6] fsl/fman: Add FMan support
Date
Hi David,
Thank you for your feedback, I'll address it and re-submit.

Regards,
Igal Liberman

> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Tuesday, December 01, 2015 11:28 PM
> To: Liberman Igal-B31950 <Igal.Liberman@freescale.com>
> Cc: netdev@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux-
> kernel@vger.kernel.org; Wood Scott-B07421 <scottwood@freescale.com>;
> Bucur Madalin-Cristian-B32716 <madalin.bucur@freescale.com>;
> pebolle@tiscali.nl; joakim.tjernlund@transmode.se; ppc@mindchasers.com;
> stephen@networkplumber.org
> Subject: Re: [v8, 2/6] fsl/fman: Add FMan support
>
> From: <igal.liberman@freescale.com>
> Date: Mon, 30 Nov 2015 14:20:58 +0200
>
> > +typedef irqreturn_t (fman_exceptions_cb)(struct fman *fman,
> > + enum fman_exceptions exception);
>
> Function and function pointer declarations and definitions should be
> indented such that the second and subsequent lines begin precisely at the
> first column after the openning parenthesis of the first line.
>
> Please audit this and fix it in your entire submission, almost ever new such
> case is done incorrectly.
>
> > + fman->state->exceptions = (EX_DMA_BUS_ERROR |
> > + EX_DMA_READ_ECC |
> > + EX_DMA_SYSTEM_WRITE_ECC |
> > + EX_DMA_FM_WRITE_ECC |
> > + EX_FPM_STALL_ON_TASKS |
> > + EX_FPM_SINGLE_ECC |
> > + EX_FPM_DOUBLE_ECC |
> > +
> EX_QMI_DEQ_FROM_UNKNOWN_PORTID |
> > + EX_BMI_LIST_RAM_ECC |
> > + EX_BMI_STORAGE_PROFILE_ECC |
> > + EX_BMI_STATISTICS_RAM_ECC |
> > + EX_MURAM_ECC |
> > + EX_BMI_DISPATCH_RAM_ECC |
> > + EX_QMI_DOUBLE_ECC |
> > + EX_QMI_SINGLE_ECC);
>
> The same applies to multi-line parenthesized expressions like this one.
> Again, please audit and fix this in your entire submission.
>
> Thanks.


\
 
 \ /
  Last update: 2015-12-02 08:21    [W:0.063 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site