lkml.org 
[lkml]   [2015]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/7] nohz: New tick dependency mask
On Tue, Dec 01, 2015 at 11:20:28PM +0100, Frederic Weisbecker wrote:
> > > + prev = fetch_or(dep, BIT_MASK(bit));
> > > + if (!prev) {
> > > + /*
> > > + * We need the IPIs to be sent from sane process context.
> >
> > Why ?
>
> Because posix timers code is all called with interrupts disabled and we can't
> send IPIs then.
>
> >
> > > + * The posix cpu timers are always set with irqs disabled.
> > > + */
> > > + schedule_work(&kick_all_work);
> > > + }
> > > +}
> > > +
> > > +/*
> > > + * Set a global tick dependency. Lets do the wide IPI kick asynchronously
> > > + * for callers with irqs disabled.
> >
> > This seems to suggest you can call this with IRQs disabled
>
> Ah right, that's a misleading comment. We need to use the _delayed() version
> when interrupts are disabled.

Why can't you use tick_nohz_full_kick_cpu() for all that, which is
usable from IRQ context and avoid all that delayed muck?


\
 
 \ /
  Last update: 2015-12-02 12:21    [W:0.168 / U:0.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site