Messages in this thread Patch in this message | | | From | Xunlei Pang <> | Subject | [PATCH v2 2/3] sched/cpupri: Cleanup of duplicate memory initialization | Date | Thu, 3 Dec 2015 12:45:00 +0800 |
| |
There is already a memset clear operation for '*cp', so we can use alloc_cpumask_var() with __GFP_ZERO instead of zalloc_cpumask_var() to avoid duplicate clear for systems without CONFIG_CPUMASK_OFFSTACK set.
Also omit "atomic_set(&vec->count, 0);".
Signed-off-by: Xunlei Pang <xlpang@redhat.com> --- kernel/sched/cpupri.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/sched/cpupri.c b/kernel/sched/cpupri.c index 981fcd7..b8f73a7 100644 --- a/kernel/sched/cpupri.c +++ b/kernel/sched/cpupri.c @@ -214,8 +214,7 @@ int cpupri_init(struct cpupri *cp) for (i = 0; i < CPUPRI_NR_PRIORITIES; i++) { struct cpupri_vec *vec = &cp->pri_to_cpu[i]; - atomic_set(&vec->count, 0); - if (!zalloc_cpumask_var(&vec->mask, GFP_KERNEL)) + if (!alloc_cpumask_var(&vec->mask, GFP_KERNEL | __GFP_ZERO)) goto cleanup; } -- 2.5.0
| |