lkml.org 
[lkml]   [2015]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.13.y-ckt 06/86] irda: precedence bug in irlmp_seq_hb_idx()
    Date
    3.13.11-ckt31 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 50010c20597d14667eff0fdb628309986f195230 ]

    This is decrementing the pointer, instead of the value stored in the
    pointer. KASan detects it as an out of bounds reference.

    Reported-by: "Berry Cheng 程君(成淼)" <chengmiao.cj@alibaba-inc.com>
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    net/irda/irlmp.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/irda/irlmp.c b/net/irda/irlmp.c
    index 98ad6ec..8ad1494 100644
    --- a/net/irda/irlmp.c
    +++ b/net/irda/irlmp.c
    @@ -1876,7 +1876,7 @@ static void *irlmp_seq_hb_idx(struct irlmp_iter_state *iter, loff_t *off)
    for (element = hashbin_get_first(iter->hashbin);
    element != NULL;
    element = hashbin_get_next(iter->hashbin)) {
    - if (!off || *off-- == 0) {
    + if (!off || (*off)-- == 0) {
    /* NB: hashbin left locked */
    return element;
    }
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-12-03 00:41    [W:4.033 / U:0.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site