Messages in this thread Patch in this message | | | Date | Fri, 18 Dec 2015 00:47:34 -0800 | From | tip-bot for Josh Poimboeuf <> | Subject | [tip:perf/core] perf build: Remove unnecessary line in Makefile.feature |
| |
Commit-ID: 26bc9b2df1f38536cdfd58df94bf8b5601eb894a Gitweb: http://git.kernel.org/tip/26bc9b2df1f38536cdfd58df94bf8b5601eb894a Author: Josh Poimboeuf <jpoimboe@redhat.com> AuthorDate: Sun, 13 Dec 2015 22:18:01 -0600 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Mon, 14 Dec 2015 12:16:15 -0300
perf build: Remove unnecessary line in Makefile.feature
This line always silently fails because it doesn't add the 'test-' prefix to the .bin file.
And it seems to be unnecessary anyway: the line immediately after it does all the individual feature checks.
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> Acked-by: Jiri Olsa <jolsa@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/554a05c18af564ba015c9e68f25730126e0f4acb.1449965119.git.jpoimboe@redhat.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/build/Makefile.feature | 1 - 1 file changed, 1 deletion(-)
diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature index 37ff4c9..b8c31ec 100644 --- a/tools/build/Makefile.feature +++ b/tools/build/Makefile.feature @@ -101,7 +101,6 @@ ifeq ($(feature-all), 1) # $(foreach feat,$(FEATURE_TESTS),$(call feature_set,$(feat))) else - $(shell $(MAKE) OUTPUT=$(OUTPUT_FEATURES) CFLAGS="$(EXTRA_CFLAGS)" LDFLAGS=$(LDFLAGS) -i -j -C $(feature_dir) $(addsuffix .bin,$(FEATURE_TESTS)) >/dev/null 2>&1) $(foreach feat,$(FEATURE_TESTS),$(call feature_check,$(feat))) endif
| |