Messages in this thread | | | Date | Fri, 18 Dec 2015 16:41:05 +0800 | From | "Wangnan (F)" <> | Subject | Re: [PATCH] tools build: Remove FEATURE-DUMP |
| |
On 2015/12/7 21:52, Jiri Olsa wrote: > On Mon, Dec 07, 2015 at 10:48:58AM +0000, Wang Nan wrote: >> Jiri introduces a FEATURE-INCLUDE file for feature checking. It >> contains same information with FEATURE-DUMP, so we can avoid generating >> FEATURE-DUMP. >> >> Following modification should ensure FEATURE_TESTS contains >> FEATURE_DISPLAY. >> >> Signed-off-by: Wang Nan <wangnan0@huawei.com> >> Cc: Jiri Olsa <jolsa@kernel.org> >> --- >> >> I haven't thoroughly tested this patch, just want to show the >> possibility of removing FEATURE-DUMP. I don't insist on this. Jiri, if >> you find this patch is not good please simply ignore it. >> >> Thank you. >> >> --- >> >> tools/build/Makefile.feature | 8 +++----- >> tools/lib/bpf/.gitignore | 1 - >> tools/lib/bpf/Makefile | 2 +- >> tools/perf/.gitignore | 1 - >> tools/perf/Makefile.perf | 2 +- >> 5 files changed, 5 insertions(+), 9 deletions(-) >> >> diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature >> index 51f8d59..98a13bd 100644 >> --- a/tools/build/Makefile.feature >> +++ b/tools/build/Makefile.feature >> @@ -123,10 +123,6 @@ define feature_print_text_code >> MSG = $(shell printf '...%30s: %s' $(1) $(2)) >> endef >> >> -FEATURE_DUMP_FILENAME = $(OUTPUT)FEATURE-DUMP$(FEATURE_USER) >> -FEATURE_DUMP := $(foreach feat,$(FEATURE_DISPLAY),feature-$(feat)($(feature-$(feat)))) >> -FEATURE_DUMP_FILE := $(shell touch $(FEATURE_DUMP_FILENAME); cat $(FEATURE_DUMP_FILENAME)) >> - >> ifeq ($(dwarf-post-unwind),1) >> FEATURE_DUMP += dwarf-post-unwind($(dwarf-post-unwind-text)) >> endif >> @@ -141,6 +137,9 @@ endif >> # features detection state. >> FEATURE_INCLUDE_FILENAME = $(OUTPUT)FEATURE-INCLUDE$(FEATURE_USER) >> >> +FEATURE_DUMP := $(foreach feat,$(FEATURE_DISPLAY),feature-$(feat)=$(feature-$(feat))) >> +FEATURE_DUMP_FILE := $(foreach feat,$(FEATURE_DISPLAY),$(shell touch $(FEATURE_INCLUDE_FILENAME); cat $(FEATURE_INCLUDE_FILENAME) | grep 'feature-$(feat)=')) > hum, this ignores dwarf-post-unwind setup, I think it needs more changes > I'll post new version
Hi Jiri,
What the current status of this patch and 'tools build: Introduce features dump include makefile'? They are in my local tree for a long time.
Thank you.
| |