lkml.org 
[lkml]   [2015]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 08/11] tty: serial: 8250: Add parentheses to macro
From
Date
On Fri, 2015-12-18 at 12:36 +0100, anton.wuerfel@fau.de wrote:
> Hello Andy,
>
> > What about the rest of the drivers under drivers/tty/serial?
> >
> > What do you propose to do with, for example, the following
> >
> > drivers/tty/serial/cpm_uart/cpm_uart_core.c:1392:#define
> > CPM_UART_CONSOLE       &cpm_scc_uart_console
> > drivers/tty/serial/cpm_uart/cpm_uart_core.c:1394:#define
> > CPM_UART_CONSOLE       NULL
> >
> > >  #else
> > >  #define SERIAL8250_CONSOLE NULL
> > >  #endif
> >
>
> thanks for your reply. Phillip and me are newcomers to kernel
> development,

Welcome!

> so we tried to touch as few files as possible and gain some
> experience in
> creating patches and communication on LKML. We will consider sending
> further patches in the future.

I see.

I don't know which way is preferable for such patches, I think Greg
usually likes when one patch touches one driver. So, this one is okay,
and other drivers can be fixed later.



> Regards,
> Phillip Raffeck
> Anton Wuerfel
>
> > --
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Intel Finland Oy
> >
> >
>
>

--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy



\
 
 \ /
  Last update: 2015-12-18 14:21    [W:0.142 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site